Jan 18, 2016

SQL PLSQL Code Review Check List ::

  • SQL PLSQL  Code Review Check List ::

  • The package/procedure/function names conform to Oracle standards(If the script is business unit specific then use the BU qualifier in the name of the script).
  • Creation script file name is same as the Package/Procedure/Function name and the file extension conforms to Oracle standards.
  • The Package Specification and Package Body are in separate files.
  • There is only one package spec or body created with each script.
  • Script contains the Oracle Copyright/Header for version control tool
  • Internal Documentation exists and it is clear and complete. (Ex. Object details and version history sections).
  • The documentation exists in the creation portion of the package/procedure/function.
  • No passwords are hard-coded in the file.
  • Show Errors exists at the end of the scripts.
  • The package/procedure/function is formatted for readability and fit standards.
  • Thereis sufficient in-line documentation. The documentation describes the business functionality and the action the queries perform.
  •  Who columns are updated correctly. (Who Columns include Last_Updated_By, Last_Update_Date...etc)
  • All SQL statements are multi-org compliant (i.e. no _ALL tables). In case there is a need to use _all tables explain the business requirement in the Notes Column.
  • No Drop statement should Exist in the Package.
  • The code uses Oracle APIs or makes call to Standard Interfaces and no direct base table inserts/updates exist.(Exception for user hook in HRMS)
  • Explain Plan for the top five queries and the trace file (with SORT option) is attached to the iSupport SR.
  • No Standard Oracle views (except Multi Org Views) should be referred in the code.
  • Usage of Dynamic SQL in the code is not recommended because it may cause High Literal issue. So It should use bind variable to avoid high parsing (in where clause of SQL).
  • Parallel hint is not present in the code to avoid performance issues.
  • Rule hint is not present in the code to avoid performance issues.

No comments:

OraApps Search

Custom Search

Search This Blog